Re: Ada bench : count words

[Tapio Kelloniemi <spam17@thack.org>]

Marius Amado Alves <amado.alves@netcabo.pt> wrote:
>> Why not use GNAT.OS_Lib.
>
>I'm trying, but the program does not work properly. It seems to
>terminate too early, and the results oscillate between 20 and 49 lines.
>I'll be damned if I understand what's happening.
[--]

>    procedure End_Line is
>    begin
>       Lines := Lines + 1;
Remove the following line:
>       Total := Total + 1;
>       End_Word;
>    end;
>
>    procedure Count_Words (S : in String) is
>    begin
>       Total := Total + S'Length;

Remove the following line (it checks every character of the buffer once more):
>       Lines := Lines + Ada.Strings.Fixed.Count (S, EOL);

>       for I in S'Range loop

Add:
           if S (I) = LF then End_Line;
           elsif Is_Separator (S (I)) then
              End_Word;

Note that the In-Word condition was checked in the loop and in In_Word.
           elsif not In_Word then Begin_Word;
>          end if;
>       end loop;
>    end;
>
>    pragma Inline (Begin_Word, End_Word, End_Line, Count_Words);
>
>begin
>    loop
>       N := GNAT.OS_Lib.Read
>         (GNAT.OS_Lib.Standin,
>          Buffer'Address,
Replace the above line with
           Buffer (Buffer'First)'Address,
And Read is given the address of first byte to fill, not some internal
pointers which are used for bounds checking.
Notice that when you leave that safe Text_IO, it is very easy to make
the same mistakes as in C (we are programming in C style).

-- 
Tapio