Re: Exiting from a function or procedure

[tmoran@bix.com]

>The trouble with leaving warnings in your code is that you can
>easily get into the habit of ignoring warnings, and we see many
  Agreed.

>Of course the pragmas Warnings (Off) and No_Return are GNAT
>specific, but there are several points to be made there:
  In this case, I could dispense with the Gnat warning by using
pragma Warnings(Off) or No_Return, but instead I'd just get new
warnings, about unrecognized pragmas, from other compilers.  So in
either case warnings will be raised, at least until all (or at least
most) Ada compilers implement one or both of those pragmas.

  In this specific case, rewriting usually removes the warning,
though it may confuse the maintenance programmer who worries
"what value is returned when things are not OK?".  It's also
subject to the previously noted problem "what happens if there's
a bug and Log_And_Raise_Error actually *does* return?"
     if not OK then
       Log_And_Raise_Error;
     end if;
     return some_value;
   end some_function;

> GNAT tends to be pretty aggressive in looking for opportunities to
> generate warnings.  Note that some compilers don't even ...
  A classic tradeoff in this case between Type 1 and Type 2
error probabilities.