Re: Naming convention to identify functions with side effects

[Ray Blaak <rAYblaaK@STRIPCAPStelus.net>]

Georg Bauhaus <rm.dash-bauhaus@futureapps.de> writes:
> I need more predicates. Since these are called before Load_Web_Page
> is called, Load_Web_Page is "pushed down" the conditional chain,
> hiding it and also blurring the distinct sources of error:
> 
>    if URL_Name /= null and then
>       Valid_Protocol (URL_Name.all) and then
>       Host_Allowed (URL_Name.all) and then
>       No_Up_Directories (URL_Name.all) and then
>       Load_Web_Page (URL_Name.all)
>    then ...
>       [stuff to do if all test succeed and the page was finally loaded]
>    else ...
>       [something has failed, maybe loading has failed, do other stuff]
>    end if;
[...]
> Finally, the programmer wanting to reduce verbosity by
> making Load_Web_Page a Boolean function now causes
> verbosity by chaining the many predicates.
> This amount by far exceeds the intended reduction in verbosity
> and renders the original intent (of saving words) mostly
> fruitless.
[...]
> At this point I remember advice from The Little Schemer
> to use little helper functions (that can be nested if
> needed). Thus,
> 
>    if Is_Acceptable (URL_Name.all) then
>       Load_Web_Page (URL_Name.all, Data);
>       Construct (Data, Result);
>    else
>       raise Syntax_Error;
>    end if;

Or, you could make Load_Web_Page only work if a page is valid:

    if Load_Web_Page (URL_Name.all, Data) then
       Construct (Data, Result);
    else
       raise Syntax_Error;
    end if;

Or, my favourite, make Load_Web_Page be a procedure that wants only valid
pages and have *it* throw any errors as needed:

       Load_Web_Page (URL_Name.all, Data); -- raises Syntax_Error if bad
       Construct (Data, Result);

-- 
Cheers,                                        The Rhythm is around me,
                                               The Rhythm has control.
Ray Blaak                                      The Rhythm is inside me,
rAYblaaK@STRIPCAPStelus.net                    The Rhythm has my soul.