Re: Optimising string handling in application

[tmoran@acm.org]

>     declare
>        Dummy : constant String :=
>          Msg (1 .. Stop_First_String) &
>          Callsign(1 .. Callsign_Length) &
>          Msg (Start_Next_String .. Msg_Length);
>     begin
>        Msg_Length := Dummy'Length;
>        Msg (1 .. Msg_Length) := Dummy;
>     end;

  You don't need the temporary (Dummy) string.  Just calculate the
length first,
      Msg_Length := Msg_Length
                    - (Start_Next_String-Stop_First_String-1)
                    + Callsign_Length;
then set Msg(1 .. Msg_Length) to the concatenation.

> since I'm calling this all over the place and need the fixed length types
>...
>     (Msg             : in out Dpu_Loc_Messages.T_Msg_Data_Str;
>      Msg_Length      : in out T_Integer_32;
>      Callsign        : in     Dpu_Loc_Messages.T_Msg_Callsign;
>      Callsign_Length : in     Positive) is
  Ah, so your abstract type is not "String", but rather a home-grown
version of Bounded_String that passes the current length as a separate
variable.  Let me guess where this code originated...