Re: Ada and "early return" - opinion/practice question

["Randy Brukardt" <randy@rrsoftware.com>]

"Dmitry A. Kazakov" <mailbox@dmitry-kazakov.de> wrote in message 
news:s2o3ud$19im$1@gioia.aioe.org...
> On 2021-03-15 17:46, John McCabe wrote:
...
> I see nothing wrong with it. In Ada:
>
>    function fn (<some parameters>) return <sometype> is
>    begin
>       if <some undesirable condition 1> then
>          return <something bad happened 1>;
>       elsif <some undesirable condition 2> then
>          return <something bad 2>;
>       elsif <some undesirable condition 3> then
>          return <something bad 3>;
>       else --Only get here if everything's good...
>          <do some real stuff>
>         return <something good>;
>    end fn;

I agree with Dmitry; it's not unusual to find this sort of structure in my 
code (usually raising exceptions, though).

With Ada 2012, some of those conditions probably ought to be in the 
precondition, so that people can see what not to do when writing their code. 
That would be:

    function fn (<some parameters>) return <sometype>
       with Pre => (not <some undesirable condition 1>) and then
                          (not <some undesirable condition 2>);

It's not always easy to decide where to draw the line, but a rule of thumb 
that I use is that the precondition should depend only on the parameters 
(not global state) and it should be easy to describe (preferably with a 
simple function call). If those are met, then it probably should be in the 
precondition -- and then the body of the function can assume the 
precondition is true.

                                   Randy.