Re: APQ

["Warren W. Gay VE3WWG" <ve3wwg@NoSpam.cogeco.ca>]

Brian May wrote:
>>>>>>"Brian" == Brian May <bam@snoopy.apana.org.au> writes:
> 
> 
>     Brian> Good point. I meant to change it in both places, but I think I ended
>     Brian> up changing it in only one place...
> 
> You were right, I missed it up.
> 
> Here is a patch that turns all methods into abstract methods.

Ok, Brian, hang on to your patches. I am trying to get my
Source Forge account reactivated (something's happened to it),
and then get this project up there.

I am surprised that that was all there was to it. I must have
made the same mistake.

> Unfortunately, I could not make Finalize abstract, the compiler
> complained that abstract methods must be visible (Finalize is in the
> private section). This restriction seems strange to me, but I am not
> going to argue with the compiler and left the function generating an
> exception at run-time.
> 
> I suspect Finalize doesn't need to be abstract, but didn't go
> exploring enough to verify why it is abstract.

Normally, you would want to override Finalize, because you
will have allocated references within the derived object
to clean up etc. However, 90% is better than nothing ;-)

> Also, I noticed that the pointers are "access all". I couldn't see any
> requirement for "all", and my code still compiles, so I changed them
> to "access". This eliminates a potential source of errors.

I can't imagine it making a practical difference here, but
perhaps I lack imagination on this point.

Warren.