Re: strange length check error

["Jeffrey R. Carter" <spam.jrcarter.not@spam.not.acm.org>]

On 01/17/2018 02:41 PM, Simon Wright wrote:
> 
>     return
>       (LENGTH(LEFT) + 1,
>        LEFT.DATA(1..LENGTH(LEFT))
>          & RIGHT
>          & LEFT.DATA((LENGTH(LEFT) + 1)..MAX_LENGTH));

I think the last part should be Left.Data (Left.Length + 1 .. Max_Length - 1) or 
(Left.Length + 2 .. Max_Length). I guess it doesn't matter what you put in those 
unused positions; you could also have (Left.Length + 2 .. Max_Length => <>).

I'd probably have written

    Result : Bounded_String;
begin -- "&"
    Result.Length := Left.Length + 1;
    Result.Data (1 .. Result.Length) := Left (1 .. Left.Length) & Right;

    return Result;

-- 
Jeff Carter
"We'll make Rock Ridge think it's a chicken
that got caught in a tractor's nuts!"
Blazing Saddles
87