Re: Ada.Strings.Fixed.Count raises Storage_Error

["Jeffrey R. Carter" <spam.jrcarter.not@spam.not.acm.org>]

On 06/26/2016 04:23 PM, rieachus@comcast.net wrote:
> 
> How about no one reports this non-existent error?  This is a category of
> problem that the ARG decided long ago should be considered pathologies.   The
> original case was a program that checked whether a task returned by a
> function was Terminated.  (The "correct" answer was True, but the program was
> totally useless for anything other than making compiler developers lives
> miserable.)
> 
> A string which ends at Integer'Last is either huge enough to raise
> Storage_Error anyway, or a clever compiler test that exists only to make
> compiler developers lives miserable.  I'm retired now, so I can say that
> without insulting customers.  And as Randy pointed out anything is allowed to
> raise Storage_Error.  That might not be user friendly, but in this case
> (Strings ending at Integer'Last) no sensible user is going to run into the
> problem.

While I mostly agree, this one, given the code presented earlier, is a 1-line
change to correct, which hardly seems like it would make developers' lives
miserable:

    while Ind <= Source'Last loop
       if Pattern = Source (Ind .. Ind) then
          ...
       else
          Ind := Ind + 1;
       end if;
    end loop;

Add

exit when Ind = Integer'Last;

after "else". I see no reason this code shouldn't correctly handle this corner case.

-- 
Jeff Carter
"[T]he Musgroves had had the ill fortune
of a very troublesome, hopeless son, and
the good fortune to lose him before he
reached his twentieth year ..."
Persuasion
154