Re: Exiting from a function or procedure

[Ray Blaak <blaak@infomatch.com>]

tmoran@bix.com writes:
> > So NEVER EVER ignore warnings, consider them as errors.  In
> > fact you might want to use -gnatwe so the compiler will
> > treat them as errors enforcing this discipline.
> 
> This is not always a good idea.  For instance
>      if OK then
>        return some_value;
>      else
>        Log_And_Raise_Error;
>      end if;
>    end some_function;
> is a perfectly legitimate paradigm in Ada that would become
> illegal in Gnat with -gnatwe, since the compiler doesn't know
> that Log_And_Raise_Error will never return.

I always put in a dummy return in these cases, just to avoid such warnings, and
for safety if the log routine ever *doesn't* raise an exception (e.g. maybe due
to some maintenance change in the future).

Of course, I also prefer a single return point, so I would have written:

      result := default_value;
      if OK then
        result := ok_value;
      else
        Log_And_Raise_Error;
      end if;
      return result;
    end some_function;

-- 
Cheers,                                        The Rhythm is around me,
                                               The Rhythm has control.
Ray Blaak                                      The Rhythm is inside me,
blaak@infomatch.com                            The Rhythm has my soul.