Re: Translating an embedded C algorithm

[Simon Wright <simon.j.wright@mac.com>]

"Steve" <nospam_steved94@comcast.net> writes:

>   ------------------------------------------------------------------------
>   -- MeasureTemperature
>   --
>   -- Calculates the temperature in �C given the ADC count by lookup
>   -- table and linear interpolation of the diode circuit characteristic.
>   --
>   -- Parameters:
>   -- AdcCount Raw ADC count.
>   --
>   -- Returns:
>   -- Temperature in �C x 10. INVALID_TEMPERATURE if out of range.
>   ------------------------------------------------------------------------
>     function MeasureTemperature( AdcCount : Adc_Reading ) return Kelvin_Tenths;

If the comment says 'degrees C' the type returned should NOT be in
Kelvin!!!

And it seems extraordinarily contrary to the Ada view of life to
return an integral value in tenths of a degree (never mind where the
zero is). This should be a real number (I don't see any virtue in
making the application deal in fixed-point, float might even be faster
on modern hardware. OK, probably not on an 8-bit microcontroller!)

And there's an inconsistency of style: AdcCount vs Adc_Reading.

And shouldn't that be ADC_Reading?

And what's with this weird non-LRM parenthesis style?

--S