Re: Optimizing Ada

[Simon Wright <simon@pushface.org>]

kennethesills@gmail.com writes:

> So I was just wondering if anyone could help me optimize my Ada code a
> bit, as well as tell me how I'm doing in terms of general code style
> and idiomatic code writing.

Looks pretty good to me (we disagree about having a space between the
subprogram name and the opening paren, but then the ALRM is wrong about
that too :-)

I'm not sure that pragma Inline is meant to work when applied to a
subprogram body, so I'd apply it to the spec (I always write specs,
because I've set the GNAT style options to standard (-gnaty), and that
warns me about missing specs - and about missing spaces, see above).

GNAT may not have implemented your Inline anyway. There's a GNAT pragma
Inline_Always, and there are switches (-gnatn, -gnatN I think) that
affect inlining. The last time I did a check, inlining made my program
slower - cache effects, presumably. That was on powerpc.

AdaCore's house rules don't allow I as a variable name (confusion
potential), they start at J.

I wonder whether your performance problem is caused by using a function?
The internal Word_Map is, I think, going to be copied to the destination
and then finalized. Could you use an out parameter? (remembering to
clear it before adding ne new content).