Re: GCC 4.8.1 for Mac OS X

[Simon Wright <simon@pushface.org>]

Bill Findlay <yaldnif.w@blueyonder.co.uk> writes:

> On 07/07/2013 19:37, in article lya9lyz06p.fsf@pushface.org, "Simon Wright"
> <simon@pushface.org> wrote:
>
>> You can find this at
>> https://sourceforge.net/projects/gnuada/files/GNAT_GCC%20Mac%20OS%20X/4.8.1/
>> 
>
> Many thanks for that, Simon.

You're welcome.

> I see it shares with GNAT GPL 2013 this foible:

Foible! excellent word.

> function hash_fn2 (the_key : naming.id)
> return   hash_code is
>    slice : constant slice_list
>       with Import, Convention => Ada, Address => the_key'Address;
>    h     : hash_code := 0;

Should that 0 be empty_hash_code?

> begin
>    for s of slice loop
>    exit when s = all_blanks_code;
>              |
>>>> warning: variable "s" is not modified in loop body [enabled by default]
>>>> warning: possible infinite loop [enabled by default]

Some sort of mistake about the flow analysis, I guess.

>       h := rotate_left(h, 2) + s;
>    end loop;
>    h := avalanche(h);
>    return (if h = empty_hash_code then empty_hash_code + 1 else h);
> end hash_fn2;