From: Jeffrey Carter <spam.jrcarter.not@spam.not.acm.org>
Subject: Re: Optimizing Ada
Date: Wed, 02 Oct 2013 09:41:38 -0700
Date: 2013-10-02T09:41:38-07:00 [thread overview]
Message-ID: <l2hic3$m65$1@dont-email.me> (raw)
In-Reply-To: <2cdd0d7d-d62c-42fc-9e5c-beed749f425a@googlegroups.com>
On 10/01/2013 09:24 PM, kennethesills@gmail.com wrote:
>
> Other than that, is the code itself clean/idiomatic enough? Not teaching myself any bad habits?
The code reads fine. There are some stylistic differences from how I'd write it,
but that's true for everyone. I haven't seen that version of Insert used very
much, so I might add a comment to remind the reader how it works when the key is
already in the map. I would probably avoid calling Update_Element when Insert
succeeds. Perhaps most important, I would be leery of writing a function that
returns a map, but that may be a requirement out of your control
--
Jeff Carter
"Go and boil your bottoms."
Monty Python & the Holy Grail
01
next prev parent reply other threads:[~2013-10-02 16:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-02 2:58 Optimizing Ada kennethesills
2013-10-02 3:47 ` Jeffrey Carter
2013-10-02 3:53 ` kennethesills
2013-10-02 4:13 ` Jeffrey Carter
2013-10-02 4:24 ` kennethesills
2013-10-02 8:11 ` Jacob Sparre Andersen
2013-10-02 10:32 ` Marius Amado-Alves
2013-10-02 14:24 ` kennethesills
2013-10-02 16:41 ` Jeffrey Carter [this message]
2013-10-02 18:58 ` John B. Matthews
2013-10-02 7:01 ` Egil H H
2013-10-02 7:16 ` Simon Wright
2013-10-02 14:43 ` kennethesills
2013-10-02 10:24 ` Marius Amado-Alves
2013-10-02 14:29 ` kennethesills
replies disabled
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox