Re: My first solution

[Jeffrey Carter <spam.jrcarter.not@spam.not.acm.org>]

On 06/14/2011 11:01 PM, juanmiuk wrote:
>
>       function Format_Num ( Width_Num  : Integer;

What does it mean to call this function with Width_Num not in Positive? Using an 
appropriate subtype in cases like this helps document how the subprogram should 
be used.

>                                         The_Number : Integer ) return
> String is
>
>          Temp_Length : My_Num := My_Num'Image(The_Number)'Length;
>          Separador      : String := (Width_Num - Temp_Length) * ' ';

These are both never assigned to, so they can be declared as constants. While 
this can assist the compiler in optimization, its primary benefit is letting the 
reader know you never change these.

Note that the Left parameter of Ada.Strings.Fixed."*" is subtype Natural. This 
will raise Constraint_Error if Width_Num - Temp_Length < 0. This helps define 
what subtype Width_Num should be, indicates some comments are probably needed to 
describe a precondition [Width_Num >= My_Num'Image (The_Number)'Length], and 
perhaps points to some ways the function can be improved [if Width_Num < 
My_Num'Image (The_Number)'Length, return My_Num'Image (The_Number)?]

"Separador" would probably be named "Padding" in English.

>       for I in My_Num range 1 .. 10 loop

for I in My_Num loop

What you have done here is effectively duplicate the functionality of 
Ada.Text_IO.Integer_IO.Put.

-- 
Jeff Carter
"Spam! Spam! Spam! Spam! Spam! Spam! Spam! Spam!"
Monty Python's Flying Circus
53