Re: Ada 0x, exception idea ?

["John R. Strohm" <strohm@airmail.net>]

"sk" <noname@myob.com> wrote in message
news:mailman.0.1059231120.320.comp.lang.ada@ada.eu.org...
> Hi,
>
> IDEA
>
> when <boolean-condition> raise <exception-name>;
>
> OR
>
> when <boolean-condition> then raise <exception-name>;
>
> OR
>
> raise <exception-name> when <boolean-condition>;
>
> SITUATION
>
> Call_Condition_Setting_Procedure (Paramters, Success);
>
> if not Success then
>      raise Call_Failed;
> end if;
>
>
> REPLACED BY
>
> Call_Condition_Setting_Procedure (Paramters, Success);
>
> when not Success raise Call_Failed;
> OR
> when not Success then raise Call_Failed;
> OR
> raise Call_Failed when not Success;
>
>
> Thoughts ?
>
> (This is a ghost of Timex/Sinclair Basic "ON ERR GOSUB" (sorry to
> pollute with the "B" word :-)).

Bletch.

As you observe, your proposed constructs are precisely equivalent to

    call_procedure(..., success);
    if not success then
      raise call_failed;
    end if;

Ada in general does not bother with unnecessary syntactic sugar, which is
what this is.

Second, and more general: If an exception should be raised SOME of the time
when the procedure fails, it probably should be raised ALL of the time, and
then the procedure itself should raise the exception, not set a status flag
and rely on the caller to check the flag and raise the exception if
necessary.

Observe that raising the exception inside the procedure is more robust: it
REQUIRES every caller to be prepared to trap the exception, and hence handle
a potential error case.  (One of the more common errors made by C
programmers is forgetting to check a pass/fail status return parameter.)