bug in ada-xref.el

bug in ada-xref.el

[Stephen A. Leake]

I've found and patched at bug in ada-xref.el (part of the ada-mode for
gnu emacs distribution). The bug prevented going to the declaration of
an identifier that contained digits as part of the name (ie
A2). Here's the diff output:

$ diff ada-xref.el ada-xref.el.orig 
409,410c409,410
< 	      (skip-chars-backward " a-zA-Z_0-9")
< 	      (looking-at "[a-zA-Z_0-9]+")
---
> 	      (skip-chars-backward " a-zA-Z_")
> 	      (looking-at "[a-zA-Z_]+")

I'm also e-mailing Markus Heritsch (listed as the author).

As a general emacs style question; it would seem to be appropriate to
define a function (maybe ada-identifier-syntax?) to return this string
to be used wherever a regexp that matches an identifier is
needed. This does not seem to be a popular idea with gnuemacs code;
any comments?

I realize this string does not enforce not starting with a digit, nor
ending with an underscore. This is because it is only used to parse
gnatf output, which does enforce those restrictions.

- Stephe
--
Stephen Leake, NASA Goddard Space Flight Center
email: Stephen.Leake@gsfc.nasa.gov