Re: AW: Translating an embedded C algorithm

[Ludovic Brenta <ludovic@ludovic-brenta.org>]

Grein, Christoph (Fa. ESG) writes:
> No, there are again some mistakes:
>
> ...
>> --| Temperature in ºC x 10. INVALID_TEMPERATURE if out of range.
>
> Incorrect: There's no INVALID_TEMPERATURE
>
> ...
>>   InterpolationDistance := (Adc_Count - MINIMUM_ADC_COUNT) mod (SPACING - 1);
>
> Wrong again: mod Spacing
>
> But: As others have pointed out, a mere translation of C code is not
> Ada. You would use constrained types rather than Integer and other
> Ada idioms (put it in a package, add context clauses, use different
> integer types for different abstractions etc...).

Right, and there would be no need for a silly INVALID_TEMPERATURE.
What *is* an invalid temperature anyway?  One that needs crutches?
One that is excused from military service? And why would you ever
return an invalid temperature to your caller? etc. etc.

-- 
Ludovic Brenta.