Re: Indentation

[Peter Chapin <PChapin@vtc.vsc.edu>]

On 2014-08-08 13:16, Jeffrey Carter wrote:

> What is new in Ada 12 that I haven't worked with yet is the aspect
> clause. This is clearly part of the type declaration, not nested within
> it, and so should be part of the type framing text. So I would probably
> indent this as
> 
> type T (Flag : Boolean := False) is record
>    case Flag is
>    when False =>
>       F1 : Float := 0.0;
>    when True =>
>       F2 : Integer := 0;
>    end case;
> end record with Unchecked_Union;

To my mind the aspects should be introduced on a separate line so they
aren't lost. I had to review the declaration above a couple of times
before I realized the aspect was even there.

I favor indenting the aspect. Consider the common case where there are
multiple declarations at the same level

   type X_Type is ...;
   type Y_Type is ...;
   procedure A(...);
   function B(...) return ...;

If you slip an aspect in at the same level of indentation as the
declaration to which it is attached it clutters things considerably.

   type X_Type is ...
   with ...;
   type Y_Type is ...
   with ...;
   procedure A(...)
   with ...;
   function B(...) return ...
   with ...;

Of course adding some blank likes would help but I still like to see the
aspect set off so its association with the previous declaration is obvious

   type X_Type is...
     with ...;
   type Y_Type is ...
     with ...;
   procedure A(...)
     with ...;
   function B(...) return ...
     with ...;

Peter