Re: Zoo question

[johnherro@aol.com (John Herro)]

Ken Garlington <garlingtonke@lmtas.lmco.com> wrote:
> Get_Next_Animal: begin -- look carefully at this code!
>    Next_Animal := Animal_ID'Succ(Next_Animal);
> exception
>    when others => Next_Animal := Animal_ID'First;
> end Get_Next_Animal;

     I realize that the point of this thread is to discuss the raising and
handling of Constraint_Error, but I think for the sake of any beginners
reading comp.lang.ada, we should point out the general rule not to use an
exception handler where a simple "if" will do.  Thus, I think most people
will agree that the above could better be written

if Next_Animal = Animal_ID'Last then
   Next_Animal := Animal_ID'First;
else
   Next_Animal := Animal_ID'Succ(Next_Animal);
end if;

     Again, I realize that's not the point of this thread, but I think
it's worth pointing out for the sake of beginners.

- John Herro
Software Innovations Technology
http://members.aol.com/AdaTutor
ftp://members.aol.com/AdaTutor