Re: Introducing memcache-ada, a memcached client in Ada

["Thomas Løcke" <tl@ada-dk.org>]

On 2010-12-20 11:16, Georg Bauhaus wrote:
> On 20/12/2010 09:25, Thomas L�cke wrote:
>> I do though have four suggestions:
>>
>> 1. Declare all the string literals ("STORED", "NOT_FOUND" and such) as
>> constants in the specification.
>
> Not sure why should they be public?  These are protocol words
> that I think a user will not want to deal with.


Do they have to be made public in order to be declared as constants in
the specification? Couldn't they be declared in the private part of the
package?

I'd prefer declaring this once:

Not_Found : constant String := "NOT_FOUND";

And then using Not_Found throughout the package, instead of having
multiple "NOT_FOUND" literals.

OTOH I do see your point about visibility.  :o)

-- 
Regards,
Thomas L�cke

Email: tl at ada-dk.org
Web: http:ada-dk.org
IRC nick: ThomasLocke