Re: My first test of github: cpros - lightweight Ada command processor

[AdaMagica <christ-usch.grein@t-online.de>]

A quote from the README:
"You have to dig into the source code of cpros_test1 to figure out more if you want to use this simple (but for me useful) tool."

Am I the only one who finds this attitude terrible and unbearable for software engineering practices?

So let's peek at the code. There is a file rsplit.ads. Hm, what's R? Split, OK... or is it the slovenian town Split?
There are no comments inside inlightening me about Rsplit.

Inside: White_Space is not really white, but OK, I would perhaps choose the same name.

There is a function Number_of_Words with a parameter FS. FS doesn't tell me anything - just a string.

Function Word, parameter FS, the same as before;
parameter S? Word_Number: Natural.

No idea what this might be...

Now switch on my superman brain: A, FS might mean Full_String and Word returns the word with position Word_Number. So S might mean Word_Separator. Why the hell doesn't the author say so? Ah, no, S is a string. So is any character in S a separator or the full S?

Ah, Word_Number starts with 0. Hm, are words within FS counted 0, 1, ... or do they start with 1? And what happens if Word_Number is out of range 0 (or 1) .. Number_of_Words. Constraint_Error or does it return ""?

Uh, ah! The parameter S is only in Word. Number_of_Words doesn't have it. Now I'm confused. How can Number_of_Words and Word work together correctly if only one knows what to use as the separator?
---------
So please, please use telling names. It doesn't take so much longer to invent them and write them down. And comment how the code is to be used!

Look at the RM to which extent the language defined subprograms are desribed. "Look into the code how it is used" is not the way to go.