Re: Is there a better (Ada) way?

["Robert I. Eachus" <rieachus@comcast.net>]

Mike Silva wrote:
> I've started writing a little CPU simulator, just for fun and to be
> doing *something* in Ada, and I want to make sure I'm not writing "C
> in Ada" when it comes to all the bit, bitfield and register
> manipulations.
> 
> Below is a typical question.  I need to add a 5-bit signed offset to a
> 16-bit register.  The way I came up with is shown on the last line of
> the example code, but I want to find out if there's a more Ada-ish way
> to do what I'm doing.  Any comments about any part of the example code
> are welcome.

>    R16 : Reg16_t;
>    PB    : Postbyte_t;
> begin
>    ....
>    R16 := R16 + Reg16_t( Integer( PB.offset5 ) mod Reg16_t'Modulus );
> -- the above line works, but is it good Ada, or C-in-Ada?

Probably not.

    R16 := R16 + Reg16_t(PB.offset5);

Should do exactly the same thing--but it doesn't.  I would probably write:

    R16 := Reg16_t(Integer(R16) + Integer(PB.offset5));

However, you need to think about what you want to happen when you add a 
positive offset to R16'Last, or a negative offset to Reg16'First.  If 
you do want wraparound semantics, you can probably suppress 
Constraint_Error and use the first line I supplied.

And incidently, it is pretty common in Ada when doing things like this 
that you have to think about which exceptional cases you don't want 
detected, instead of which special cases you do want to handle.


-- 
                                                     Robert I. Eachus

"Quality is the Buddha. Quality is scientific reality. Quality is the 
goal of Art. It remains to work these concepts into a practical, 
down-to-earth context, and for this there is nothing more practical or 
down-to-earth than what I have been talking about all along...the repair 
of an old motorcycle."  -- from Zen and the Art of Motorcycle 
Maintenance by Robert Pirsig