Re: 'Valid, subtypes and constraint checking

["Robert I. Eachus" <rieachus@comcast.net>]

Peter Amey wrote:

> My confidence has now been shaken by a test case for a compiler, as yet 
> unnamed, which raises constraint error for the initial assignment of an 
> invalid value in ExternalPort to Temp.  Is this correct behaviour?  If 
> it _is_ correct, how can you ever validate external volatile data?
> 
> (Horrible strawman solution: do an unchecked conversion of External_Port 
> into Temp and then do the validity check).
> 
> Thoughts?

Define a type that matches any possible value of ExternalPort.  That is 
the type of ExternalPort, whatever else you may think. Call it 
Port_Type, for now. To convert it to your internal type, you may be able 
to do

function My_Convert is
     new Unchecked_Conversion(Port_Type, Internal_Type);

Temp := My_Convert(ExternalPort);

However, you may have to do:

Temp1: Port_Type;
Temp2: Internal_Type;

Temp1 := ExternalPort;
if Internal_Type'Valid(My_Convert(Temp1))
then Temp2 := My_Convert(Temp1);
end if;

Don't worry about the apparent calling of My_Convert twice.  For most 
conversions, instances of Unchecked_Conversion generate no code.  (The 
special cases include when the source is a slice or a packed record 
component, which certainly isn't happening here.)

It sounds like the type you are converting to is one where the compiler 
assures itself that all values are in range or correct in some way.  For 
example it could check that pointers are divisible by four for some 
hardware.  These are the cases where you need the second construction.

-- 
                                                     Robert I. Eachus

"Quality is the Buddha. Quality is scientific reality. Quality is the 
goal of Art. It remains to work these concepts into a practical, 
down-to-earth context, and for this there is nothing more practical or 
down-to-earth than what I have been talking about all along...the repair 
of an old motorcycle."  -- from Zen and the Art of Motorcycle 
Maintenance by Robert Pirsig