Re: HELP ! Problems with Get and Put in Generic Procedure

[Jeffrey Carter <spam@spam.com>]

Tanya wrote:

R. Eachus addressed your question, but there's another likely 
misunderstanding on your part I'd like to mention.

> 
> (generic spec file)  ******************************************
> 
>  GENERIC
>       
>       TYPE ElementType IS PRIVATE;         -- any nonlimited type
>       TYPE IndexType IS ( <> );            -- any discrete type for
>                                            -- index value
>       TYPE ArrayType IS ARRAY (IndexType RANGE <>) OF ElementType;
>       
>       WITH PROCEDURE Read (Item : IN ElementType);

Mode "in" seems odd for a procedure named Read.

>       
>    PROCEDURE Get_Array_Generic (List : IN OUT ArrayType);
>    -- Input : Array type and input file stream.
>    -- Action: Will read in elements and store in array.
>    -- Output: Array filled with elements.
> 
> 
> (generic body file)  ********************************************
> 
> PROCEDURE Get_Array_Generic (List : IN OUT ArrayType) IS
>    -------------------------------------------------------------------
>    -- Input : Array type and input file stream.
>    -- Action: Will read in elements and store in array.
>    -- Output: Array filled with elements.
>    -------------------------------------------------------------------
>    
>       Index : IndexType;
>       Element : ElementType;
>       
>    BEGIN  -- Get_Array_Generic
>       
>       Index := List'Last;               -- initialize array index to
>                                         -- first subscript

This assignment is the only place this variable is mentioned in this 
procedure. Since you're not doing anything with it, why not eliminate it?

>       
>       FOR Index IN List'RANGE LOOP
>                      
>             Read (Item => Element);        -- read elements into array
>          
>          -- store data into the array
>          
>             List (Index) := Element;
>          
>          END LOOP;
>  
>    END Get_Array_Generic;

Your code will look better to most of us if you use all lower case for 
reserved words, and use underlines instead of case to separate words in 
identifiers (Index_Type, not IndexType).

-- 
Jeff Carter
"It's all right, Taggart. Just a man and a horse being hung out there."
Blazing Saddles