Re: Newbie (code review)

Re: Newbie (code review)

[Jim Rogers]

Ok, I see a few small things I would do differently.

I would place the declaration of procedure "free" in the list
package body, not in the private part of the specification.

I also wonder why you have "withed" Ada.Exceptions in main when
you are not using anything from that package.

Jim Rogers

Holger Zwar wrote:

> hi ada community,
> i'm learning ada (reading j. barnes progr. in ada 2nd ed.) since 2 weeks and
> i like it very much (i'm coding c++ and java at work). now i think it's a
> good time to get some feedback. i'm playing around with a double-linked list
> (i know that there are public good libs and i don't want to reinvent the
> wheel ;-) and i think i'm doing right. but i don't won't to make thoose
> typical beginner mistakes. so what do you (ada profs) think of my code. what
> is bad? what should i avoid?
> thanks in advance
> holger zwar
> 
> 
> 

Re: Newbie (code review)

[Michal Nowak]

On 2002-04-25 at 23:55 Holger Zwar wrote:

>hi ada community,
>i'm learning ada (reading j. barnes progr. in ada 2nd ed.) since 2 weeks
>and
>i like it very much (i'm coding c++ and java at work). now i think it's a
>good time to get some feedback. i'm playing around with a double-linked
>list
>(i know that there are public good libs and i don't want to reinvent the
>wheel ;-) and i think i'm doing right. but i don't won't to make thoose
>typical beginner mistakes. so what do you (ada profs) think of my code.
>what
>is bad? what should i avoid?
>thanks in advance

Hi,

Although I'm not professional, I think I may advice you looking on
"Ada 95 Quality and Style: Guidelines for Professional Programmers".
You may find some useful informations there (I don't want to say 
your code is bad - in fact it does not look like a newbie code, just
to let you know, that such helpful document exists). It is available on
http://www.adaic.org/standards/ada95.html
in various formats.

Good luck and enjoy,
Mike