comp.lang.ada
 help / color / mirror / Atom feed
From: Jim Rogers <jimmaureenrogers@worldnet.att.net>
Subject: Re: Newbie (code review)
Date: Fri, 26 Apr 2002 01:31:58 GMT
Date: 2002-04-26T01:31:58+00:00	[thread overview]
Message-ID: <3CC8AE13.5020309@worldnet.att.net> (raw)
In-Reply-To: 3cc87b22$0$10098$6e365a64@newsreader02.highway.telekom.at

Ok, I see a few small things I would do differently.

I would place the declaration of procedure "free" in the list
package body, not in the private part of the specification.

I also wonder why you have "withed" Ada.Exceptions in main when
you are not using anything from that package.

Jim Rogers

Holger Zwar wrote:

> hi ada community,
> i'm learning ada (reading j. barnes progr. in ada 2nd ed.) since 2 weeks and
> i like it very much (i'm coding c++ and java at work). now i think it's a
> good time to get some feedback. i'm playing around with a double-linked list
> (i know that there are public good libs and i don't want to reinvent the
> wheel ;-) and i think i'm doing right. but i don't won't to make thoose
> typical beginner mistakes. so what do you (ada profs) think of my code. what
> is bad? what should i avoid?
> thanks in advance
> holger zwar
> 
> 
> 




       reply	other threads:[~2002-04-26  1:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <3cc87b22$0$10098$6e365a64@newsreader02.highway.telekom.at>
2002-04-26  1:31 ` Jim Rogers [this message]
2002-04-28 17:23 ` Newbie (code review) Michal Nowak
replies disabled

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox