Re: short-circuit control forms

[Jeffrey Carter <jeffrey.carter@boeing.com>]

"James A. Krzyzanowski" wrote:
> 
> Looking for expert opinions...
> 
> We have a company standard which states:
> "standard => Use short-circuit control forms to specify the order of
>              conditions when the failure of one condition means that
>              the other condition will raise an exception.
>  guideline => Avoid short-circuit control forms otherwise."
> 
> Our software engineers believe that using short-circuit control forms
> will make our software more efficient (speed-wise).  So, they have been
> replacing every "and" with "and then" and every "or" with "or else".
> 
> If using "and then" and "or else" will make our software quicker, and
> then the compiler doesn't optimize any better anyway, does anybody have
> a good reason why we should NOT use short-circuit control forms?

Do you know that using short-circuit forms makes your software quicker?

If you have measured the speed with and without the short-circuit forms,
and found it to be statistically different at the p=0.1 level or better
AND the difference is necessary for the software to function correctly,
then your software engineers are justified in their actions.

If not, you do not have software engineers. You have coders who are
wasting their time and the company's money on ignorant FUD, and
introducing a new source of error into working software. At best you
should fire them and replace them with software engineers; at worst you
should require them to adhere to your company standard unless they have
justification for deviating.

-- 
Jeffrey Carter