Re: sort function

[Jeffrey Carter <jeffrey.carter@boeing.com>]

sc297 wrote:
> 
> help . ive written a sort funtion, but for the life of me i cant work
> out what i have done wrong. help me ada people
> 
> with ada.text_io, ada.integer_text_io;
> use ada.text_io, ada.integer_text_io;

You never use anything from these packages, so why with and use them?

> 
> procedure sort( Data: in out Vector ) is

Here you reference type Vector, which is undefined (a type declaration
must occur before you can reference it).

> Type Vector is array( Positive Range <> ) of Integer;

Here you define type Vector, but it's too late.

> 
> temp : integer:=0;
> status : boolean := false;
> swap:integer:=0;
> Begin
> while status /= true loop

If you rewrite this as

loop
   exit when Status;


you can see that Status needs a better name, like Done or Finished.

>   For I in data'first..data'last-1 loop
>     If data(I)>data(I+1) then
>       temp:=data(I);
>       data(I):=data(I+1);
>       data(I+1):=temp;
>         swap:=swap+1;
>     Else
>       Null;
>     End if;
> 
>     If swap = 0 then
>       Status := true;
>     Else
>       Status:=false;
>     End if;

This if can be replaced by

Status := Swap = 0;

which is clearer.

>   End loop;
> swap:=0;
> End loop;
> End sort;

It looks to me as if Swap is really a Boolean.

You should ask John English about this. That's what he's there for.

--
Jeffrey Carter