Re: Banging the Ada Drum.

[adacrypt <austin.obyrne@hotmail.com>]

On Feb 28, 10:49 am, Martin <mar...@thedowies.com> wrote:
> On Feb 28, 9:39 am, adacrypt <austin.oby...@hotmail.com> wrote:
> [snip]
>
>   FOR I in 30 ..1030 LOOP
>     A(I) := Alices_Digital_Signature.GetUnits(Numin => I);
>     B(I) := Alices_Digital_Signature.GetUnits(Numin => I);
>   END LOOP;
>
> Don't explicitly re-use the array limits in loops, prefer:
>
>    for I in A'Range loop
>       A (I) := ...
>
> Now the compiler may not inject checks on "A (I)" as it knows that the
> range of "I" is derived directly from "A".
>
> Why have different types for A and B - they are both just arrays of
> Integer with the same index. If you really want to make them
> different, you could do:
>
>    type Index is range 30 .. 1_030;
>    type A_Array_Type is array (Index) of Integer;
>    type B_Array_Type is new A_Array_Type;
>
>    A : A_Array_Type;
>    B : B_Array_Type;
>
> BTW, are you assuming Integer is 32-bits? Because it doesn't have to
> be...it could be as small as 16 bits or larger than 32.
>
> -- Martin

Martin,

May I explain that I am  a retired Ship's Engineer in my late
seventies - I am taking your points on board very self-consciously and
normally would leap at the improvements you suggest - in fact could I
ask you to continue and I will build these improvements into my
existing work.

If I was younger I would have a far more ambitious outlook in
improving my Ada - please keep on pointing out improvements that I can
make.

Also,

Would you please consider rewriting this entire software in your
version of it and I will post that up on my website under yor name or
even your own website with a link from mine.

Thanks again.

- adacrypt