From mboxrd@z Thu Jan  1 00:00:00 1970
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on polar.synack.me
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham
	autolearn_force=no version=3.4.4
X-Google-Thread: 103376,587e0e0a16d65b10
X-Google-Attributes: gid103376,domainid0,public,usenet
X-Google-Language: ENGLISH,ASCII-7-bit
Path: 
 g2news2.google.com!news3.google.com!feeder.news-service.com!feeder.erje.net!feeder2.news.saunalahti.fi!feeder1.news.saunalahti.fi!nntp.inet.fi!central1.inet.fi!inet.fi!read4.inet.fi.POSTED!53ab2750!not-for-mail
Newsgroups: comp.lang.ada
Subject: Re: Invade wikipedia!
References: <l6k0og.o0o.ln@hunter.axlog.fr>
 <go4gqp$5nj$1@octagram.motzarella.org> <gir5og.o5s.ln@hunter.axlog.fr>
 <go66s6$m76$1@octagram.motzarella.org>
 <49a6d506$0$32680$9b4e6d93@newsspool2.arcor-online.net>
 <4a18f335-30f6-4216-8376-0310eb560445@p11g2000yqe.googlegroups.com>
 <49a7ced2$0$31342$9b4e6d93@newsspool4.arcor-online.net>
 <t0tq29ariugm.aftb8vcp4aeg$.dlg@40tude.net>
 <uzlg266ae.fsf@no.email.thanks.invalid>
 <vo7g5a9tdgei$.553b23ltkai3$.dlg@40tude.net>
From: Anders Wirzenius <anders@no.email.thanks.invalid>
Message-ID: <ur61dkf5z.fsf@no.email.thanks.invalid>
User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.3 (windows-nt)
Cancel-Lock: sha1:VexwlWKM/5ZhO1VdJtdOL4P5ivs=
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Date: Wed, 04 Mar 2009 05:52:56 GMT
NNTP-Posting-Host: 194.251.142.2
X-Complaints-To: abuse@inet.fi
X-Trace: read4.inet.fi 1236145976 194.251.142.2 (Wed,
 04 Mar 2009 07:52:56 EET)
NNTP-Posting-Date: Wed, 04 Mar 2009 07:52:56 EET
Organization: Sonera Customer
Xref: g2news2.google.com comp.lang.ada:4886
Date: 2009-03-04T05:52:56+00:00
List-Id: <comp.lang.ada>

"Dmitry A. Kazakov" <mailbox@dmitry-kazakov.de> writes:

> On Tue, 03 Mar 2009 14:16:09 GMT, Anders Wirzenius wrote:
>
>> "Dmitry A. Kazakov" <mailbox@dmitry-kazakov.de> writes:
>> 
>>>    procedure Insertion_Sort (A: in out Mug_List) is
>>>    begin
>>>       for I in A'First + 1..A'Last loop
>>>          declare
>>>             Value : constant Mug := A (I);
>>>             J     : Mug_Number   := I - 1;
>>>          begin
>>>             while A (J) > Value loop
>>>                A (J + 1) := A (J);
>>>                exit when J = A'First;
>>>                J := J - 1;
>>>             end loop;
>>>             A (J) := Value;
>>               ^^^^^
>> How  about    A (J+1) := Value;
>
> J+1 is always greater than A'First. Consider sorting (2, 1). 
>
>>>          end;
>>>       end loop;
>>>    end Insertion_Sort;

Consider sorting (1,2). Then A (J) < Value and the procedure
jumps directly to A (J) := Value.

How about 

   procedure Insertion_Sort (A: in out Mug_List) is
   begin
      for I in A'First+1 .. A'Last loop
         declare
            Value : constant Mug := A (I);
            J     : Mug_Number   := I;
         begin
            loop
               exit when Value >= A (Mug_Number'Pred (J));
               A (J) := A (Mug_Number'Pred (J));
               J := Mug_Number'Pred (J);
               exit when J = A'First;
            end loop;
            A (J) := Value;
         end;
      end loop;
   end Insertion_Sort;

-- 
Anders