Re: Ada.Containers.Indefinite_Ordered_Maps of gcc 4.0.1 has bug ?

[Matthew Heaney <matthewjheaney@earthlink.net>]

"Y.Tomino" <demoonlit@panathenaia.halfmoon.jp> writes:

> I send a-ciorma.ad? as attachments.
> (C:\mingw\lib\gcc\i686-pc-mingw32\4.0.1\adainclude\a-ciorma.ads,
>   C:\mingw\lib\gcc\i686-pc-mingw32\4.0.1\adainclude\a-ciorma.adb)
> 
> I built gcc 4.0.1 with "--enable-languages=c,ada,c++ --prefix=/mingw".


You appear to have an older version of the sources. Here's the problem:


   function Copy_Node (Source : Node_Access) return Node_Access is
      Target : constant Node_Access :=
         new Node_Type'(Parent  => null,
                        Left    => null,
                        Right   => null,
                        Color   => Source.Color,
                        Key     => Source.Key,
                        Element => Source.Element);
   begin
      return Target;
   end Copy_Node;


In this implementation of the indefinite container, keys and elements
are allocated.  The code fragment above simply copies the pointers, but
this is wrong, since Adjust must make its own copy.

This is an old bug, that was fixed a few months ago.  I'm surprised
you're seeing it.  You can simply patch your copy like this:

   function Copy_Node (Source : Node_Access) return Node_Access is
      K : Key_Access := new Key_Type'(Source.Key.all);
      E : Element_Access;
   begin
      E := new Element_Type'(Source.Element.all);

      return new Node_Type'(Parent  => null,
                            Left    => null,
                            Right   => null,
                            Color   => Source.Color,
                            Key     => K,
                            Element => E);
   exception
      when others =>
         Free_Key (K);
         Free_Element (E);
         raise;
   end Copy_Node;


Alternatively you can grab a copy of that module from the repository at
<http://charles.tigris.org/> .

I would submit a bug report either to the FSF or to AdaCore, to ensure
the fix wends its way to public GCC repositories.  This bug was found
and fixed in AdaCore's sources a while ago, so I don't understand why
you don't have the latest, corrected version.

-Matt