From mboxrd@z Thu Jan  1 00:00:00 1970
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on polar.synack.me
X-Spam-Level: 
X-Spam-Status: No, score=-0.3 required=5.0 tests=BAYES_00,
	REPLYTO_WITHOUT_TO_CC autolearn=no autolearn_force=no version=3.4.4
X-Google-Language: ENGLISH,ASCII-7-bit
X-Google-Thread: 103376,723d750f4b80c21e
X-Google-Attributes: gid103376,public
X-Google-ArrivalTime: 2001-10-16 02:50:32 PST
Path: 
 archiver1.google.com!news1.google.com!newsfeed.stanford.edu!newsfeed.berkeley.edu!news-hog.berkeley.edu!ucberkeley!enews.sgi.com!nntp1.phx1.gblx.net!nntp.gblx.net!nntp.gblx.net!nntp-cust.primenet.com!news.streamgate.de!gerhard.nospam
From: gerhard.nospam@bigfoot.de (Gerhard =?iso-8859-1?Q?H=E4ring?=)
Newsgroups: comp.lang.ada
Subject: Re: a little help
Date: Tue, 16 Oct 2001 11:50:21 +0200
Organization: Streamgate AG
Message-ID: <slrn9snplt.ja.gerhard.nospam@lilith.hqd-internal>
References: <9qgrgh$1f10$1@newsreader1.mclink.it>
Reply-To: gerhard@bigfoot.de
NNTP-Posting-Host: 213-196-68-75.hosts.streamgate.de
X-Trace: news.streamgate.de 1003224535 17737 213.196.68.75 (16 Oct 2001
 09:28:55 GMT)
X-Complaints-To: news@streamgateag.de
NNTP-Posting-Date: Tue, 16 Oct 2001 09:28:55 +0000 (UTC)
User-Agent: slrn/0.9.6.3 (Linux)
Xref: archiver1.google.com comp.lang.ada:14643
Date: 2001-10-16T11:50:21+02:00
List-Id: <comp.lang.ada>

On Tue, 16 Oct 2001 10:39:14 +0200, F <phosphorus@libero.it> wrote:
>Hello world,
>          i'm trying to learn Ada but i've a lot of problems with the
>operations with strings.
>In particular i've a procedure for the input:
>
>type st is new string;
>procedure leggis (j: in out st) is
>    c:character;
>begin
>    while not end_of_line loop
>        get(c); b(ind):=c; ind:=ind+1;
>    end loop;
>end leggis;
>
>
>when i call the first time this procedure i obtain the input string but the
>second time nothing happens.....
>I think that character return remains in the keyboard buffer, how can I
>resolve this problem?????

Looks like you're not telling us the whole story. Where do the b and ind
variables come from? Looks like they *should* be put in the procedure
but they're now declared and initialized outside in (global?) variables.
This means you get so-called side-effects when running the procedure:
the procedure isn't self-contained but changes state elsewhere. This
usually leads to bugs sooner or later.

Solution: put all variables into the proecedure and initialize them
there, too. ind should be initialized to 0 if I see this correctly.

If you want to improve the code even further, you can make the j
parameter "out" instead of "in out", but even better would be to make
the whole thing a function instead.

Gerhard
-- 
mail:   gerhard <at> bigfoot <dot> de       registered Linux user #64239
web:    http://www.cs.fhm.edu/~ifw00065/    OpenPGP public key id 86AB43C0
public key fingerprint: DEC1 1D02 5743 1159 CD20  A4B6 7B22 6575 86AB 43C0
reduce(lambda x,y:x+y,map(lambda x:chr(ord(x)^42),tuple('zS^BED\nX_FOY\x0b')))