From mboxrd@z Thu Jan  1 00:00:00 1970
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on polar.synack.me
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00
	autolearn=unavailable autolearn_force=no version=3.4.4
Path: 
 eternal-september.org!reader01.eternal-september.org!reader02.eternal-september.org!.POSTED!not-for-mail
From: "Jeffrey R. Carter" <spam.jrcarter.not@spam.not.acm.org>
Newsgroups: comp.lang.ada
Subject: Re: strange length check error
Date: Wed, 17 Jan 2018 22:37:50 +0100
Organization: Also freenews.netfront.net; news.tornevall.net;
 news.eternal-september.org
Message-ID: <p3ofne$gbu$1@dont-email.me>
References: <14a35359-150a-4aa6-b437-19c74381be4b@googlegroups.com>
 <d90f7446-0adc-4541-8a8e-937997ff8fd7@googlegroups.com>
 <ly3734alen.fsf@pushface.org>
 <e795335b-734a-4e1b-9bd5-fd6769335c6d@googlegroups.com>
 <ca6ffdc8-6e50-45cf-9ab5-43854525bdb9@googlegroups.com>
 <lyy3kw8uvt.fsf@pushface.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Injection-Date: Wed, 17 Jan 2018 21:37:50 -0000 (UTC)
Injection-Info: reader02.eternal-september.org;
 posting-host="a9f0dbf263f9b0ea2411e89fb837fc9f";
	logging-data="16766"; mail-complaints-to="abuse@eternal-september.org";
	posting-account="U2FsdGVkX1+GUgBQdZ3PWsImGXXA1o7obkb77PzaS84="
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.0
In-Reply-To: <lyy3kw8uvt.fsf@pushface.org>
Content-Language: en-US
Cancel-Lock: sha1:lGM67CpTGtnpoKekJg6oVjRhr1Q=
Xref: reader02.eternal-september.org comp.lang.ada:49967
Date: 2018-01-17T22:37:50+01:00
List-Id: <comp.lang.ada>

On 01/17/2018 02:41 PM, Simon Wright wrote:
> 
>     return
>       (LENGTH(LEFT) + 1,
>        LEFT.DATA(1..LENGTH(LEFT))
>          & RIGHT
>          & LEFT.DATA((LENGTH(LEFT) + 1)..MAX_LENGTH));

I think the last part should be Left.Data (Left.Length + 1 .. Max_Length - 1) or 
(Left.Length + 2 .. Max_Length). I guess it doesn't matter what you put in those 
unused positions; you could also have (Left.Length + 2 .. Max_Length => <>).

I'd probably have written

    Result : Bounded_String;
begin -- "&"
    Result.Length := Left.Length + 1;
    Result.Data (1 .. Result.Length) := Left (1 .. Left.Length) & Right;

    return Result;

-- 
Jeff Carter
"We'll make Rock Ridge think it's a chicken
that got caught in a tractor's nuts!"
Blazing Saddles
87