From mboxrd@z Thu Jan  1 00:00:00 1970
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on polar.synack.me
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00
	autolearn=unavailable autolearn_force=no version=3.4.4
Path: 
 eternal-september.org!reader01.eternal-september.org!reader02.eternal-september.org!news.eternal-september.org!mx02.eternal-september.org!feeder.eternal-september.org!gandalf.srv.welterde.de!news.jacob-sparre.dk!loke.jacob-sparre.dk!pnx.dk!.POSTED!not-for-mail
From: Tero Koskinen <tero.koskinen@iki.fi>
Newsgroups: comp.lang.ada
Subject: Re: ANN:  GNAT GPL 2015 Atmel SAM4S Ravenscar patches
Date: Wed, 29 Jul 2015 20:47:24 +0300
Organization: Jacob Sparre Andersen Research & Innovation
Message-ID: <mpb3jd$s29$1@loke.gir.dk>
References: <2681e2fb-97b8-4910-82e9-28091ee793d5@googlegroups.com>
 <lysi87xxha.fsf@pushface.org>
NNTP-Posting-Host: 87-95-3-0.bb.dnainternet.fi
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
X-Trace: loke.gir.dk 1438192045 28745 87.95.3.0 (29 Jul 2015 17:47:25 GMT)
X-Complaints-To: news@jacob-sparre.dk
NNTP-Posting-Date: Wed, 29 Jul 2015 17:47:25 +0000 (UTC)
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64;
 rv:31.0) Gecko/20100101 Thunderbird/31.7.0
In-Reply-To: <lysi87xxha.fsf@pushface.org>
Xref: news.eternal-september.org comp.lang.ada:27134
Date: 2015-07-29T20:47:24+03:00
List-Id: <comp.lang.ada>

29.7.2015, 9:57, Simon Wright kirjoitti:
> Patrick Noffke <patrick.noffke@gmail.com> writes:
>
>> A makefile and patches be found here:
>> https://github.com/patricknoffke/ada-mcu
>>
>> I have added runtime support for various peripherals, with BSD
>> 3-Clause license.
>
> It appears that you have (maybe not completely consistently) altered
> AdaCore's copyright notices, added in an FSF copyright notice, and added
> back the GCC Runtime Library Exception. I don't think you're entitled to
> do those things.

Do you mean sections like this:
https://github.com/patricknoffke/ada-mcu/blob/master/bb-runtimes-gpl-2015.patch#L4164 
?

I think Patrick's patch is done correctly. He has basically rewritten 
the files, only the filenames (and some function names) are same, which 
is why the diff shows stuff that way.

However, issues/questions like this ("did you really modify GPL 
code/remove the copyright headers?") show that it is a bad idea to base 
any of the work on GNAT GPL. Also, new work should use separate files,
not just a huge patch which replaces the old files.

So, Patrick should probably rebase his work on top of FSF GNAT and 
include Atmel SAM4S specific code in a dedicated source directory.

Here are my examples for STM32F4:
https://bitbucket.org/tkoskine/gnat-arm-app-skeleton/src/ab141a07860925a7c19d333c30b6084a041d9325?at=default
https://bitbucket.org/tkoskine/embedded-arm-gnat-rts/src/128d104166de?at=default
https://bitbucket.org/tkoskine/embedded-arm-gnat-build/src

GNAT build script (and possible patches) is in one repository 
(embedded-arm-gnat-build). GNAT Ada runtime is in another repository 
(embedded-arm-gnat-rts), and STM32F4 peripheral code is in the third 
repository (gnat-arm-app-skeleton).

You could probably use same repository for all pieces, but you need to 
put them in separate directories at least.

Yours,
  Tero