From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on polar.synack.me X-Spam-Level: X-Spam-Status: No, score=-1.3 required=5.0 tests=BAYES_00,MAILING_LIST_MULTI, REPLYTO_WITHOUT_TO_CC autolearn=no autolearn_force=no version=3.4.4 X-Google-Language: ENGLISH,ASCII-7-bit X-Google-Thread: 103376,bcbb1958406dce8f X-Google-Attributes: gid103376,public X-Google-ArrivalTime: 2002-11-26 03:29:03 PST Path: archiver1.google.com!news1.google.com!newsfeed.stanford.edu!news.tele.dk!news.tele.dk!small.news.tele.dk!newsfeed.icl.net!newsfeed.fjserv.net!proxad.net!freenix!enst.fr!not-for-mail From: "Grein, Christoph" Newsgroups: comp.lang.ada Subject: Re: Renames: use of it.... Date: Tue, 26 Nov 2002 12:21:38 +0100 (MET) Organization: ENST, France Sender: comp.lang.ada-admin@ada.eu.org Message-ID: Reply-To: comp.lang.ada@ada.eu.org NNTP-Posting-Host: marvin.enst.fr Mime-Version: 1.0 Content-Type: TEXT/plain; charset=us-ascii X-Trace: avanie.enst.fr 1038310143 74481 137.194.161.2 (26 Nov 2002 11:29:03 GMT) X-Complaints-To: usenet@enst.fr NNTP-Posting-Date: Tue, 26 Nov 2002 11:29:03 +0000 (UTC) Return-Path: X-Authentication-Warning: mail.eurocopter.com: uucp set sender to using -f Content-MD5: i9YHuzfrmeFo6kicRWA/8g== X-Mailer: dtmail 1.2.1 CDE Version 1.2.1 SunOS 5.6 sun4u sparc Errors-To: comp.lang.ada-admin@ada.eu.org X-BeenThere: comp.lang.ada@ada.eu.org X-Mailman-Version: 2.0.13 Precedence: bulk X-Reply-To: "Grein, Christoph" List-Unsubscribe: , List-Id: comp.lang.ada mail<->news gateway List-Post: List-Help: List-Subscribe: , Errors-To: comp.lang.ada-admin@ada.eu.org X-BeenThere: comp.lang.ada@ada.eu.org Xref: archiver1.google.com comp.lang.ada:31230 Date: 2002-11-26T12:21:38+01:00 > Hi all, > I am doing a code review for a one of the module in flight management > computer. > One the procedure is calling an another procedure > (COMMANDS.EXECUTE_SCROLL) from a package called COMMANDS. > In package COMMANDS the declaration of the procedure EXECUTE_SCROLL is > as follows : > procedure EXECUTE_SCROLL (MCDU_ID : in > MMI_APPLICATION_TYPES.T_MCDU_ID; > DIRECTION : in CONTEXT_TYPES.T_DIRECTION) > renames ACTION_CONTROLER.EXECUTE_SCROLL; > > All the procedures in this package is rename of a procedure in package > ACTION_CONTROLER or some other package. Why is it so?Why can't use the > procedure from the package ACTION_CONTROLER itself(i.e instead of > calling COMMANDS.EXECUTE_SCROLL why can't they use > ACTION_CONTROLER.EXECUTE_SCROLL)?Is the package COMMANDS really > required? This looks very much like a design issue, probably Ada 83. I presume ACTION_CONTROLER has more operations than EXECUTE_SCROLL, but only those made visible in COMMANDS via renaming statements shall be visible to the outside. So there is probably a coding guideline that clients shall use COMMANDS only and not ACTION_CONTROLER directly. This is work-around for the (in Ada 83) missing feature of private children. Also in Ada 95, sometimes you cannot make everything private as you would like to, so such a rule helps to limit visibility. In our project, we use a lot of such renaming packages.