From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on polar.synack.me X-Spam-Level: X-Spam-Status: No, score=-1.3 required=5.0 tests=BAYES_00,MAILING_LIST_MULTI, REPLYTO_WITHOUT_TO_CC autolearn=no autolearn_force=no version=3.4.4 X-Google-Language: ENGLISH,ASCII-7-bit X-Google-Thread: 103376,16c5d42d1a58946d X-Google-Attributes: gid103376,public X-Google-ArrivalTime: 2002-04-28 10:22:03 PST Path: archiver1.google.com!news1.google.com!newsfeed.stanford.edu!news.ems.psu.edu!news.cis.ohio-state.edu!news.maxwell.syr.edu!fr.clara.net!heighliner.fr.clara.net!freenix!enst!enst.fr!not-for-mail From: Michal Nowak Newsgroups: comp.lang.ada Subject: Re: Newbie (code review) Date: Sun, 28 Apr 2002 19:23:02 +0200 Organization: ENST, France Sender: comp.lang.ada-admin@ada.eu.org Message-ID: References: <3cc87b22$0$10098$6e365a64@newsreader02.highway.telekom.at> Reply-To: comp.lang.ada@ada.eu.org NNTP-Posting-Host: marvin.enst.fr Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7BIT X-Trace: avanie.enst.fr 1020014522 95262 137.194.161.2 (28 Apr 2002 17:22:02 GMT) X-Complaints-To: usenet@enst.fr NNTP-Posting-Date: Sun, 28 Apr 2002 17:22:02 +0000 (UTC) Return-Path: In-reply-to: <3cc87b22$0$10098$6e365a64@newsreader02.highway.telekom.at> X-Mailer: Calypso Version 3.30.00.00 (3) Errors-To: comp.lang.ada-admin@ada.eu.org X-BeenThere: comp.lang.ada@ada.eu.org X-Mailman-Version: 2.0.8 Precedence: bulk X-Reply-To: vinnie@inetia.pl List-Help: List-Post: List-Subscribe: , List-Id: comp.lang.ada mail<->news gateway List-Unsubscribe: , Errors-To: comp.lang.ada-admin@ada.eu.org X-BeenThere: comp.lang.ada@ada.eu.org Xref: archiver1.google.com comp.lang.ada:23198 Date: 2002-04-28T19:23:02+02:00 On 2002-04-25 at 23:55 Holger Zwar wrote: >hi ada community, >i'm learning ada (reading j. barnes progr. in ada 2nd ed.) since 2 weeks >and >i like it very much (i'm coding c++ and java at work). now i think it's a >good time to get some feedback. i'm playing around with a double-linked >list >(i know that there are public good libs and i don't want to reinvent the >wheel ;-) and i think i'm doing right. but i don't won't to make thoose >typical beginner mistakes. so what do you (ada profs) think of my code. >what >is bad? what should i avoid? >thanks in advance Hi, Although I'm not professional, I think I may advice you looking on "Ada 95 Quality and Style: Guidelines for Professional Programmers". You may find some useful informations there (I don't want to say your code is bad - in fact it does not look like a newbie code, just to let you know, that such helpful document exists). It is available on http://www.adaic.org/standards/ada95.html in various formats. Good luck and enjoy, Mike