From mboxrd@z Thu Jan  1 00:00:00 1970
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on polar.synack.me
X-Spam-Level: 
X-Spam-Status: No, score=-0.6 required=5.0 tests=BAYES_00,DATE_IN_PAST_24_48
	autolearn=no autolearn_force=no version=3.4.4
X-Google-Thread: a07f3367d7,229b63b453788905
X-Google-Attributes: gida07f3367d7,public,usenet
X-Google-NewGroupId: yes
X-Google-Language: ENGLISH,ASCII-7-bit
Received: by 10.66.77.230 with SMTP id v6mr347971paw.20.1344480263367;
        Wed, 08 Aug 2012 19:44:23 -0700 (PDT)
Path: 
 p10ni18121247pbh.1!nntp.google.com!border1.nntp.dca.giganews.com!nntp.giganews.com!nrc-news.nrc.ca!News.Dal.Ca!news.litech.org!news.stack.nl!eternal-september.org!feeder.eternal-september.org!mx04.eternal-september.org!.POSTED!not-for-mail
From: Simon Wright <simon@pushface.org>
Newsgroups: comp.lang.ada
Subject: Re: Sledgehammer Indexing Tools
Date: Tue, 07 Aug 2012 11:55:48 +0100
Organization: A noiseless patient Spider
Message-ID: <m2d3330y4r.fsf@nidhoggr.home>
References: <4ec110af-691d-4100-8cd8-b99efda5351b@googlegroups.com>
Mime-Version: 1.0
Injection-Info: mx04.eternal-september.org;
 posting-host="edf2659fbb8cb6d4b5f62db4b36ac1e6";
	logging-data="19284"; mail-complaints-to="abuse@eternal-september.org";
	posting-account="U2FsdGVkX19u9ntfNaLN7vMPhX6l+phn1M/4UeV56u4="
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (darwin)
Cancel-Lock: sha1:JAyyQGeFqAp3ZrCuRrJsiTCbHsk=
	sha1:8sGEf0g0dJyBZDXfCDkGl84GHWE=
Content-Type: text/plain
Date: 2012-08-07T11:55:48+01:00
List-Id: <comp.lang.ada>

3-toed Sloth <john@peppermind.com> writes:

> I've just released some document indexing tools for GNU/Linux on
> launchpad which are written in Ada:
>
> https://launchpad.net/sledgehammer
>
> They come with a makefile and a GPS project file. They heavily depend
> on external converters, so please check the dependencies in the Readme
> file before trying the indexer out.
>
> Comments and suggestions for improvement are welcome. Please bear in
> mind that I'm a hobbyist and this is only the second Ada program I've
> ever written, though, so please don't be too harsh with your
> criticisms. :-)

Erich,

Thanks for sharing.

Since I'm on Mac OS X I'd probably have trouble meeting the
preconditions! However, a comment or two --

Your repo contains .npp and .adt files, both of these are generated and
shouldn't be there.

In - for example - external_lookup.ads, you've "use"d several of your
own packages. I'd think that you can reasonably expect readers to know
the standard library (for example, Indefinite_Vectors), but how can they
know where Occurrences is defined?

Again in external_lookup.ads, couldn't most of the private part be moved
to the package body?

Have you looked at GNAT.OS_Lib, which contains various Spawn
subprograms?