Re: Strings with discriminated records

[Simon Wright <simon@pushface.org>]

NiGHTS <nights@unku.us> writes:

> I've expanded my example to include a strange run-time crash I am getting.
>
> Type Message (Length : Positive) is new Ada.Finalization.Controlled with record
>     Text  :  String (1 .. Length);
>     Cstr  :  Interfaces.C.Strings.chars_ptr;
> end record;
>        
> function Create (Value : String) return Message is
> begin
>     return (
>         Ada.Finalization.Controlled with Length => Value'Length, 
>         Text => Value, 
>         Cstr => Interfaces.C.Strings.New_String (Value) 
>     );
> end Create; 
>
> procedure Finalize (
>     M : in out Message
> ) is
> begin
>     Interfaces.C.Strings.Free ( M.Cstr ); -- Crashes here
> end;
>
> declare
>     M : Message := Create ("Hello World");
> begin
>     null;
> end; 
>
> Why does my program crash on Finalization?

Maybe Finalize is getting called twice? You should set M.Cstr to
Null_Ptr after freeing it.