From mboxrd@z Thu Jan  1 00:00:00 1970
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on polar.synack.me
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00
	autolearn=unavailable autolearn_force=no version=3.4.4
Path: 
 eternal-september.org!reader01.eternal-september.org!reader02.eternal-september.org!news.eternal-september.org!news.eternal-september.org!news.eternal-september.org!.POSTED!not-for-mail
From: Simon Wright <simon@pushface.org>
Newsgroups: comp.lang.ada
Subject: Re: GCC 4.8.1 for Mac OS X
Date: Mon, 08 Jul 2013 08:25:31 +0100
Organization: A noiseless patient Spider
Message-ID: <ly61wlzf6c.fsf@pushface.org>
References: <lya9lyz06p.fsf@pushface.org>
	<CDFFA40E.32082%yaldnif.w@blueyonder.co.uk>
Mime-Version: 1.0
Content-Type: text/plain
Injection-Info: mx05.eternal-september.org;
 posting-host="a849a84efccf4ec3e3fdf530b5c53bc9";
	logging-data="20637"; mail-complaints-to="abuse@eternal-september.org";
	posting-account="U2FsdGVkX1/MnEnmApN3nMiNvuR/gCZ8bLuS5+G5cZ8="
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (darwin)
Cancel-Lock: sha1:2B9osU/hQ2Wtz3Rc6gvse67X+nc=
	sha1:1fW4ORJUrTBQTIn8VqkptHPZxZ4=
Xref: news.eternal-september.org comp.lang.ada:16148
Date: 2013-07-08T08:25:31+01:00
List-Id: <comp.lang.ada>

Bill Findlay <yaldnif.w@blueyonder.co.uk> writes:

> On 07/07/2013 19:37, in article lya9lyz06p.fsf@pushface.org, "Simon Wright"
> <simon@pushface.org> wrote:
>
>> You can find this at
>> https://sourceforge.net/projects/gnuada/files/GNAT_GCC%20Mac%20OS%20X/4.8.1/
>> 
>
> Many thanks for that, Simon.

You're welcome.

> I see it shares with GNAT GPL 2013 this foible:

Foible! excellent word.

> function hash_fn2 (the_key : naming.id)
> return   hash_code is
>    slice : constant slice_list
>       with Import, Convention => Ada, Address => the_key'Address;
>    h     : hash_code := 0;

Should that 0 be empty_hash_code?

> begin
>    for s of slice loop
>    exit when s = all_blanks_code;
>              |
>>>> warning: variable "s" is not modified in loop body [enabled by default]
>>>> warning: possible infinite loop [enabled by default]

Some sort of mistake about the flow analysis, I guess.

>       h := rotate_left(h, 2) + s;
>    end loop;
>    h := avalanche(h);
>    return (if h = empty_hash_code then empty_hash_code + 1 else h);
> end hash_fn2;