From mboxrd@z Thu Jan  1 00:00:00 1970
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on polar.synack.me
X-Spam-Level: 
X-Spam-Status: No, score=0.4 required=5.0 tests=BAYES_00,FORGED_MUA_MOZILLA
	autolearn=no autolearn_force=no version=3.4.4
X-Google-Thread: 103376,f02a96c85b47538d
X-Google-NewGroupId: yes
X-Google-Attributes: gida07f3367d7,domainid0,public,usenet
X-Google-Language: ENGLISH,ASCII-7-bit
Received: by 10.68.59.229 with SMTP id c5mr3584673pbr.6.1320875534138;
        Wed, 09 Nov 2011 13:52:14 -0800 (PST)
Path: 
 h5ni18029pba.0!nntp.google.com!news2.google.com!goblin1!goblin.stu.neva.ru!news.tornevall.net!.POSTED!not-for-mail
From: Jeffrey Carter <spam.jrcarter.not@spam.not.acm.org>
Newsgroups: comp.lang.ada
Subject: Re: Read Windows login username in Ada 95
Date: Wed, 09 Nov 2011 14:52:11 -0700
Organization: TornevallNET - http://news.tornevall.net
Message-ID: <j9esnb$2tv$1@tornado.tornevall.net>
References: <9192369.445.1320801564794.JavaMail.geo-discussion-forums@yqbl36>
 <268750.2183.1320871677246.JavaMail.geo-discussion-forums@yqan20>
NNTP-Posting-Host: 4b78b4f7bb79eaee85bf03bdebd61f6f
Mime-Version: 1.0
X-Trace: 2c4020043628663affe1794f5d3d5997
X-Complaints-To: abuse@tornevall.net
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US;
 rv:1.9.2.23) Gecko/20110922 Thunderbird/3.1.15
X-Complaints-Language: Spoken language is english or swedish - NOT ITALIAN,
 FRENCH, GERMAN OR ANY OTHER LANGUAGE!
In-Reply-To: <268750.2183.1320871677246.JavaMail.geo-discussion-forums@yqan20>
X-UserIDNumber: 1738
X-Validate-Post: 
 http://news.tornevall.net/validate.php?trace=2c4020043628663affe1794f5d3d5997
X-Complaints-Italiano: Non abbiamo padronanza della lingua italiana - se
 mandate una email scrivete solo in Inglese, grazie
X-Posting-User: 0243687135df8c4b260dd4a9a93c79bd
Xref: news2.google.com comp.lang.ada:14376
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Date: 2011-11-09T14:52:11-07:00
List-Id: <comp.lang.ada>

On 11/09/2011 01:47 PM, Rego, P. wrote:
>
> function GetUsername return String is
>     function GetEnv (Variable : String) return Interfaces.C.Strings.chars_ptr;

This no doubt expects a NUL-terminated string. I would use Char_Array for the 
parameter and To_C to convert an Ada string passed to it.

>     pragma Import (C, GetEnv, "getenv");
>
>     Command : constant String := "USERNAME";
>     Answer_Ptr : constant Interfaces.C.Strings.chars_ptr := GetEnv (Command);

You're not giving it a NUL-terminated string.

>     Answer : constant String := Interfaces.C.Strings.Value (Answer_Ptr);
> begin
>     return Answer;

Who is responsible for freeing Answer_Ptr?

> end GetUsername;

As Obry suggested, Ada.Environment_Variables is an all-Ada way to do this.

-- 
Jeff Carter
"Alms for an ex-leper!"
Monty Python's Life of Brian
75