From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on polar.synack.me X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham autolearn_force=no version=3.4.4 X-Google-Thread: 103376,bdcca6db8294fb00 X-Google-NewGroupId: yes X-Google-Attributes: gida07f3367d7,domainid0,public,usenet X-Google-Language: ENGLISH,ASCII-7-bit Path: g2news2.google.com!news3.google.com!feeder.news-service.com!94.75.214.39.MISMATCH!aioe.org!news.tornevall.net!.POSTED!not-for-mail From: Jeffrey Carter Newsgroups: comp.lang.ada Subject: Re: Introducing memcache-ada, a memcached client in Ada Date: Mon, 20 Dec 2010 12:36:45 -0700 Organization: TornevallNET - http://news.tornevall.net Message-ID: References: <4d0f1316$0$23759$14726298@news.sunsite.dk> NNTP-Posting-Host: 16adf2804820ef8d8a004c6590362978 Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: 088c60989d77486f46874e0d8da02ea5 X-Complaints-To: abuse@tornevall.net User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.13) Gecko/20101208 Thunderbird/3.1.7 X-Complaints-Language: Spoken language is english or swedish - NOT ITALIAN, FRENCH, GERMAN OR ANY OTHER LANGUAGE! In-Reply-To: <4d0f1316$0$23759$14726298@news.sunsite.dk> X-UserIDNumber: 1738 X-Validate-Post: http://news.tornevall.net/validate.php?trace=088c60989d77486f46874e0d8da02ea5 X-Complaints-Italiano: Non abbiamo padronanza della lingua italiana - se mandate una email scrivete solo in Inglese, grazie X-Posting-User: 0243687135df8c4b260dd4a9a93c79bd Xref: g2news2.google.com comp.lang.ada:17043 Date: 2010-12-20T12:36:45-07:00 List-Id: On 2010-12-20 01:43, R Tyler Croy wrote: > > I look forward to any comments or suggestions as to the code > quality/structure. I have looked only at the specification, since that's the only part a client should need to look at. Initial impressions: I see a number of declarations in the visible part of the specification that are not referenced in the visible part nor needed for the client to use the package. Only things needed in the visible part or needed by the client to use the package should appear in the visible part. [In order of preference, things should be declared 1. In the body 2. In the private part (Is Ada the only language with private parts?) 3. In the visible part] Similarly, context clauses should use "private with" for things only referenced in the private part. The type Flags and the Set_Flags parameters of that type are not documented in the spec; if possible, they should be. In particular, the effect of the default value for Set_Flags should be described. The meaning of the expiration parameters, and especially of their default values, should be documented. The default of zero would seem to mean immediate expirations, which doesn't seem very useful. The meaning of the Boolean return values from some of the functions (which also appear as parameters) is unclear and should be documented. Some exceptions appear at the end of the visible part. Presumably some of the operations may raise these exceptions, but which operations raise which exceptions, and in what circumstances, is not documented. Since declarations should appear before they are referenced, the exception declarations should appear before the comments in which they are referenced. -- Jeff Carter "Crucifixion's a doddle." Monty Python's Life of Brian 82