Re: This MIDI stuff, would someone be interested in reviewing my code?

["Jeffrey R. Carter" <spam.jrcarter.not@spam.acm.org>]

John McCabe wrote:
> 
> 1) Perhaps I should be using limited withs in some places to get
> access to the primitive operators/functions of the stuff in
> Interfaces.C/.strings and Win32 etc.

That's not what "limited with" is for.

I notice that you "use" a lot of pkgs, but then refer to things using full 
names. You should get rid of those "use" clauses, and add "use type" clauses in 
your declarative part as needed.

> 3) Would it be more appropriate to use something like
> Win32.UINT'Image() instead of getting an instantiation of the
> Modular_IO package?

That's a matter of taste and needed functionality.

My first comments would be to use common Ada naming conventions: Dev_ID, 
Num_Input_Devices, and so on.

I also prefer to see "loop" and "then" on the same line as "for" and "if". This 
looks like a C-family person thinking they're equivalent to '{'.

I would make Numinputdevices and Numoutputdevices constants. For this small 
example, I would do the same with Midiincaps and Midioutcaps; there's really no 
need to free them, since they're around for the entire program, and will be 
freed when the program exits.

> with Interfaces.C; use Interfaces.C;
> with Interfaces.C.Strings; use Interfaces.C.Strings;

"with Interfaces.C.Strings;" implies "with Interfaces; with Interfaces.C;", so 
there's no reason to have both.

> with Win32; use Win32;
> with Win32.Mmsystem; use Win32.Mmsystem;

Ditto.

>       for devId in Win32.UINT range 0..(NumInputDevices - 1)
>       loop

These parentheses are unnecessary.

>          res := Win32.Mmsystem.midiInGetDevCaps(devId,
>                                                 midiInCaps,
> 
> (Win32.Mmsystem.MIDIINCAPS'size * Win32.BYTE'size));

So are the internal ones here.

You've already been warned about sprinkling OS-dependent stuff throughout your code.

-- 
Jeff Carter
"C's solution to this [variable-sized array parameters] has real
problems, and people who are complaining about safety definitely
have a point."
Dennis Ritchie
25