Re: What do you think about this?

[Anh Vo <anhvofrcaus@gmail.com>]

On Tuesday, June 23, 2015 at 12:51:08 PM UTC-7, Laurent wrote:
> On Tuesday, 23 June 2015 16:21:17 UTC+2, Stephen Leake  wrote:
> > I did not download and compile it, but I did browse around it a bit.
> 
> That's why I like git.
> 
> with Ada.Strings.Bounded;
> with Ada.Strings.Fixed;
> 
> package Common_Defs_BCI is
> 
>    V_String_Length  : constant :=  64;
> 
>    package V_String is new
>      Ada.Strings.Bounded.Generic_Bounded_Length (V_String_Length);
> 
>    function "+" (Right : V_String.Bounded_String) return String
>                  renames
>      V_String.To_String;
> 
>    function "+" (Right : String) return V_String.Bounded_String
>    is (V_String.To_Bounded_String (Right));
> 
>    function Trim (Right : String) return V_String.Bounded_String is
>      (V_String.To_Bounded_String (Ada.Strings.Fixed.Trim (Right, Ada.Strings.Both)));
> 
> end Common_Defs_BCI;

I would suggest to improve the last two functions with the following preconditions. That means any attempt to pass an String whose length is longer than 40 characters will be slapped by the run time.

   --...
   with pre => Right <= V_String_Length;

Anh Vo