Suspicious reentrant semaphore

[Jano <nono@celes.unizar.es>]

Hello everybody,

I'm developing a multitasking program that runs OK for several hours. At 
some indeterminate moment, a bunch of its tasks cease to respond, and I 
have a strong suspicion that the culprit is a semaphore package I've 
done.

The purpose is to have a semaphore which can be called more than a time 
_by the same task_, and that must be released the same amount of times. 
Nested calls, simply.

Leaving aside why I have done that (yes, poor design, I'm removing it 
anyway ;-), I would like to know if my package is right or really is 
there some race condition. Please comment on it. I know that 
Current_Task shouldn't be called inside entries (in fact Gnat doesn't 
allow it, I tried :-P) but doesn't complain about it being used in 
barriers. Anyways, I have a (maybe wrong) feel about that being related 
to the deadlock.

Here are the spec and body:

P.s: I can guarantee that never use it without the controlled object, so 
no calls to V should occur without a previous P.

P.s: If it turns out that this isn't the culprit, I will amuse you ;-) 
with more samples of my code ^_^

Thanks!

------------SPEC---------------------------------------------------

package Adagio.Monitor is

   use Ada.Task_identification;
   
   protected type Semaphore is
      entry P (Owner : Task_id);
      entry V;
   private
      Caller : Task_id := Null_task_id;           -- Requester
      In_use : Natural := 0;                      -- Times requested
   end Semaphore;

   type Semaphore_access is access all Semaphore;

   -- Use: 
   -- S : aliased Semaphore;
   -- M : Object (S'access);
   type Object (S : access Semaphore) is new 
      Finalization.Limited_Controlled with null record;

   procedure Initialize (this : in out Object);
   procedure Finalize   (this : in out Object);

end Adagio.Monitor;

---------------------BODY----------------------------------

package body Adagio.Monitor is

   protected body Semaphore is

      entry P (Owner: Task_id) 
         when In_use = 0 or else Current_task = Caller is
      begin
         Caller := Owner;
         In_use := In_use + 1;
      end P;

      entry V when In_use > 0 and Current_task = Caller is
      begin
         In_use := In_use - 1;
      end V;

   end Semaphore;

   -- Get
   procedure Initialize (this : in out Object) is
   begin
      this.S.P (Current_task);
   end Initialize;

   -- Release
   procedure Finalize (this : in out Object) is
   begin
      this.S.V;
   end Finalize;

end Adagio.Monitor;

-- 
-------------------------
Jano
402450.at.cepsz.unizar.es
-------------------------