From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on polar.synack.me X-Spam-Level: X-Spam-Status: No, score=-1.3 required=5.0 tests=BAYES_00,INVALID_MSGID autolearn=no autolearn_force=no version=3.4.4 X-Google-Language: ENGLISH,ASCII-7-bit X-Google-Thread: fac41,9a0ff0bffdf63657 X-Google-Attributes: gidfac41,public X-Google-Thread: 1108a1,9a0ff0bffdf63657 X-Google-Attributes: gid1108a1,public X-Google-Thread: f43e6,9a0ff0bffdf63657 X-Google-Attributes: gidf43e6,public X-Google-Thread: 103376,4b06f8f15f01a568 X-Google-Attributes: gid103376,public From: doylep@ecf.toronto.edu (Patrick Doyle) Subject: Re: Software landmines (loops) Date: 1998/09/08 Message-ID: #1/1 X-Deja-AN: 389157161 X-Nntp-Posting-Host: spark19.ecf Sender: news@ecf.toronto.edu (News Administrator) References: <35f51e53.480<904556531.666222@ <6t42kg$son$1@hirame.wwa.com> Organization: University of Toronto, Engineering Computing Facility Newsgroups: comp.lang.eiffel,comp.object,comp.software-eng,comp.lang.ada Date: 1998-09-08T00:00:00+00:00 List-Id: In article <6t42kg$son$1@hirame.wwa.com>, Robert Martin wrote: > >duncan@yc.estec.esa.nlx wrote in message ... > >>Even with an indent level of only 2 spaces, the code would >>regularly march off the right of the screen and wrap around, >>making readability, maintenance and reformatting in the event >>of a change an absolute nightmare. > >In this extreme situation it seems clear that you'd want to use multiple >exits. The cost of the se/se solution in this context probably outweighs >any benefits that might be derived. It seems clear, IMHO, that what's really needed is a better data abstraction. Having multiple functions which all traverse a data structure and do all sorts of error checking along the way seems to scream for a better abstraction. Of course, this is based on limited info about the project, and the design certainly could have been justified. -PD -- -- Patrick Doyle doylep@ecf.toronto.edu