From mboxrd@z Thu Jan  1 00:00:00 1970
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on polar.synack.me
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham
	autolearn_force=no version=3.4.4
X-Google-Thread: 103376,229b63b453788905
X-Google-NewGroupId: yes
X-Google-Attributes: gida07f3367d7,domainid0,public,usenet
X-Google-Language: ENGLISH,ASCII-7-bit
Received: by 10.66.86.6 with SMTP id l6mr1851810paz.1.1344339678688;
        Tue, 07 Aug 2012 04:41:18 -0700 (PDT)
Path: 
 c10ni92542pbw.0!nntp.google.com!news2.google.com!postnews.google.com!glegroupsg2000goo.googlegroups.com!not-for-mail
From: john@peppermind.com
Newsgroups: comp.lang.ada
Subject: Re: Sledgehammer Indexing Tools
Date: Tue, 7 Aug 2012 04:41:11 -0700 (PDT)
Organization: http://groups.google.com
Message-ID: <9ccd79a7-df35-4854-97de-a35554b963f0@googlegroups.com>
References: <4ec110af-691d-4100-8cd8-b99efda5351b@googlegroups.com>
 <m2d3330y4r.fsf@nidhoggr.home>
NNTP-Posting-Host: 88.214.186.9
Mime-Version: 1.0
X-Trace: posting.google.com 1344339671 9685 127.0.0.1 (7 Aug 2012 11:41:11
 GMT)
X-Complaints-To: groups-abuse@google.com
NNTP-Posting-Date: Tue, 7 Aug 2012 11:41:11 +0000 (UTC)
In-Reply-To: <m2d3330y4r.fsf@nidhoggr.home>
Complaints-To: groups-abuse@google.com
Injection-Info: glegroupsg2000goo.googlegroups.com; posting-host=88.214.186.9;
 posting-account=nd46uAkAAAB2IU3eJoKQE6q_ACEyvPP_
User-Agent: G2/1.0
Content-Type: text/plain; charset=ISO-8859-1
Date: 2012-08-07T04:41:11-07:00
List-Id: <comp.lang.ada>

Hi Simon,

> Your repo contains .npp and .adt files, both of these are generated and
> 
> shouldn't be there.

Yep, I agree. It seems that gnatclean does not remove them. I also need to edit the exclude lists for bazaar.

> 
> 
> In - for example - external_lookup.ads, you've "use"d several of your
> 
> own packages. I'd think that you can reasonably expect readers to know
> 
> the standard library (for example, Indefinite_Vectors), but how can they
> 
> know where Occurrences is defined?

That I don't understand.They are defined in the respective source packages. Do you mean I should comment the use of these packages better in the source code?

> Again in external_lookup.ads, couldn't most of the private part be moved
> 
> to the package body?

Good question. I vaguely remember that I instantiated generic packages and assigned values to variables in the private part on purpose, but I can't remember exactly why. I'll check that.

By the way, to make this more portable I probably shouldn't hardcode the paths to the helper utilities either. Is there a "standard" way to find executable paths on Linux and other Unix-like systems?

Anyway, thanks a lot for the feedback! 


Best,

Erich