From mboxrd@z Thu Jan  1 00:00:00 1970
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on polar.synack.me
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham
	autolearn_force=no version=3.4.4
X-Google-Thread: 103376,93a8020cc980d113
X-Google-Attributes: gid103376,public
X-Google-Language: ENGLISH,ASCII-7-bit
Path: 
 g2news1.google.com!news2.google.com!news.glorb.com!news.mixmin.net!feed.xsnews.nl!border-2.ams.xsnews.nl!216.196.110.149.MISMATCH!border2.nntp.ams.giganews.com!nntp.giganews.com!feeder3.cambrium.nl!feed.tweaknews.nl!not-for-mail
From: Ludovic Brenta <ludovic@ludovic-brenta.org>
Newsgroups: comp.lang.ada
Subject: Re: What is wrong with Ada?
References: <1176150704.130880.248080@l77g2000hsb.googlegroups.com>
	<zyBSh.44138$oV.14776@attbi_s21> <461B52A6.20102@obry.net>
	<awirc4gv13.fsf@hod.lan.m-e-leypold.de> <461BA892.3090002@obry.net>
	<yeabxgnsrj.fsf@hod.lan.m-e-leypold.de>
	<82dgve.spf.ln@hunter.axlog.fr>
	<1176226291.589741.257600@q75g2000hsh.googlegroups.com>
	<4eaive.6p9.ln@hunter.axlog.fr> <sa4ps6apjb7.fsf@margay.local>
	<1176396382.586729.195490@y5g2000hsa.googlegroups.com>
	<n3r6qpea4p.fsf@hod.lan.m-e-leypold.de>
	<f00106$tqm$1@f04n12.cac.psu.edu>
	<c98xcs8jao.fsf@hod.lan.m-e-leypold.de> <46249099.4080408@obry.net>
	<PM00042E503F06FEA3@tilopa.unknown.dom> <4624EC4F.9060301@obry.net>
Date: Tue, 17 Apr 2007 22:53:49 +0200
Message-ID: <87647u67tu.fsf@ludovic-brenta.org>
User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux)
Cancel-Lock: sha1:4rA5TCcLbPOpVIo0hbDkNNDX8u0=
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Organization: Tele2
X-Trace: 
 DXC=A6^aBV]heZOHKIOHYdA:0A6`Y6aWje^YJOgg:1`jo;CKm@[o=d]MiOM`4>Ko897OBLUbO`7hB^?YO
Xref: g2news1.google.com comp.lang.ada:15096
Date: 2007-04-17T22:53:49+02:00
List-Id: <comp.lang.ada>

Pascal Obry writes:
> Thanks for your answers. But I was more thinking about being two people
> on a project not necessary two behind the screen at the same time. Code
> review can be done at any time with the right setup (sending mails for
> each check-in for example) it is possible to make code review as
> something "normal". Many developers seems to not like somebody looking
> at their code, if every piece of code is sent to a dev mailing-list it
> changes things, making code more visible by default.
>
> I do think that a single developer on a project is bad for the overall
> quality... I'm just looking for so data to backup this idea :)
>
> Well this has nothing to do with Ada, so I'm completely off topic, fell
> free to ignore :)

I agree wholeheartedly.  A few years ago, I would start each day
reviewing my teammates' commits in the version control system, and I
also encouraged them to do likewise.  We caught many latent or actual
bugs even before testing that way.  Furthermore, it allowed us to know
the entire source base intimately, even on those parts we weren't
directly involved in.

Now I work in avionics and we have formal code reviews instead.  They
tend to take place after everything is written, and I miss the
closed-loop feedback I had with daily reviews.

-- 
Ludovic Brenta.