From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on polar.synack.me X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=unavailable autolearn_force=no version=3.4.4 Path: buffer1.nntp.dca1.giganews.com!border1.nntp.dca1.giganews.com!nntp.giganews.com!news.glorb.com!peer02.iad.highwinds-media.com!news.highwinds-media.com!feed-me.highwinds-media.com!post02.iad.highwinds-media.com!news.flashnewsgroups.com-b7.4zTQh5tI3A!not-for-mail From: Stephen Leake Newsgroups: comp.lang.ada Subject: Re: What do you think about this? References: <9894cde7-2cf8-4060-be65-857812ad7b09@googlegroups.com> <17436268-aceb-461f-bdcf-eee8436cd0e6@googlegroups.com> Date: Tue, 23 Jun 2015 09:21:14 -0500 Message-ID: <86y4jaqzdx.fsf@stephe-leake.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (windows-nt) Cancel-Lock: sha1:ioZvQinJPBEzjNxE6jK6mw2Yod0= MIME-Version: 1.0 Content-Type: text/plain X-Complaints-To: abuse@flashnewsgroups.com Organization: FlashNewsgroups.com X-Trace: 9ea2c55896b5ce97f808411079 X-Received-Bytes: 1568 X-Received-Body-CRC: 416069521 Xref: number.nntp.giganews.com comp.lang.ada:193734 Date: 2015-06-23T09:21:14-05:00 List-Id: Laurent writes: > I have uploaded the files to git, > > https://github.com/Chutulu/Generateur_Trame_Vitek2.git I did not download and compile it, but I did browse around it a bit. The code looks clean and well-organized, but it lacks comments. What is a "biogramme"? What is a "dossier"? etc. What is the whole thing supposed to do? There are cases where a function returns a V_String but could return a plain String; in general, unless the result _must_ be a V_String for some reason, it is better to return a String; then the caller can just use it without conversion, or declare a local variable to hold it. -- -- Stephe