From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on polar.synack.me X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=unavailable autolearn_force=no version=3.4.4 Path: eternal-september.org!reader01.eternal-september.org!reader02.eternal-september.org!news.eternal-september.org!mx02.eternal-september.org!feeder.eternal-september.org!feeder.erje.net!us.feeder.erje.net!usenet.blueworldhosting.com!feeder01.blueworldhosting.com!peer02.iad.highwinds-media.com!news.highwinds-media.com!feed-me.highwinds-media.com!post02.iad.highwinds-media.com!news.flashnewsgroups.com-b7.4zTQh5tI3A!not-for-mail From: Stephen Leake Newsgroups: comp.lang.ada Subject: Re: OpenToken 6.0 released References: <85r3rlg6dd.fsf@stephe-leake.org> <2384a5b9-51ea-49c9-b3cd-595292fcd48f@googlegroups.com> Date: Fri, 24 Apr 2015 04:37:00 -0500 Message-ID: <85618leukj.fsf@stephe-leake.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (windows-nt) Cancel-Lock: sha1:M5tKH16R0k1QfB14NpjRukFFABk= MIME-Version: 1.0 Content-Type: text/plain X-Complaints-To: abuse@flashnewsgroups.com Organization: FlashNewsgroups.com X-Trace: 58191553a0ebee97f808418428 X-Received-Bytes: 1627 X-Received-Body-CRC: 2900916511 Xref: news.eternal-september.org comp.lang.ada:25589 Date: 2015-04-24T04:37:00-05:00 List-Id: jan.de.kruyf@gmail.com writes: > Stephe, hallo. > > Thanks for all the good work, and here is some small inconsistency in the makefile: > > org.opentoken-6.0a/build/release/Install.make > > line 30: > cp lib/libopentoken* $(I_BIN) > > I am puzzled why the lib files should be copied to the bin directory The only file that matches that pattern is libopentoken.dll, which needs to be in the bin directory on Windows (as the comment says). Patches for linux welcome, but my general approach is to leave installation to the platform installer packages. > all the more since you dont check that a bin directory is created, It's computed starting on line 6: INSTALL_DIR ?= $(dir $(shell which gnatls)).. prefix=$(INSTALL_DIR) I_BIN = $(prefix)/bin so it has to exist if you can compile OpenToken > and it also does not get cleaned up in the install-clean : rule. That is an oversight. -- -- Stephe