From mboxrd@z Thu Jan  1 00:00:00 1970
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on polar.synack.me
X-Spam-Level: 
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,
	PP_MIME_FAKE_ASCII_TEXT autolearn=no autolearn_force=no version=3.4.4
X-Google-Language: ENGLISH,ASCII
X-Google-Thread: 103376,e44577c74a66122
X-Google-Attributes: gid103376,public
X-Google-ArrivalTime: 2002-12-22 11:18:40 PST
Path: 
 archiver1.google.com!news1.google.com!newsfeed.stanford.edu!bloom-beacon.mit.edu!iad-peer.news.verio.net!news.verio.net!newsfeed.icl.net!newsfeed.fjserv.net!newsfeed.freenet.de!news.freenet.de!not-for-mail
From: see@messagebody.com (Jan)
Newsgroups: comp.lang.ada
Subject: Re: what's wrong with random
Date: Sun, 22 Dec 2002 19:17:25 GMT
Message-ID: <3e060eb9.4328921@news.freenet.de>
References: <3e05fbdf.4089296@news.freenet.de>
 <wccr8c9ew5y.fsf@shell01.TheWorld.com>
X-Newsreader: Forte Free Agent 1.21/32.243
NNTP-Posting-Host: 213.7.190.83
X-Trace: 1040584720 news.freenet.de 8302 213.7.190.83:1226
X-Complaints-To: abuse@freenet.de
Xref: archiver1.google.com comp.lang.ada:32205
Date: 2002-12-22T19:17:25+00:00
List-Id: <comp.lang.ada>

On Sun, 22 Dec 2002 18:38:33 GMT, Robert A Duff
<bobduff@shell01.TheWorld.com> wrote:

>I think you want the generator to be global to Generate_FileName.
>Otherwise, it will be reinitialized each time Generate_FileName
>is called.
>
>- Bob

What do you mean? Can you give an example?
Here is a working version:
--------
with Ada.Text_IO, Ada.Numerics.Discrete_Random;
use  Ada.Text_IO;

procedure Random_Test is 

   valid_chars : String :=
"abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ"
                     & "0123456789!�$%&()=@+-;_#";  

   subtype Int_Slice is Integer range valid_chars'range;
   package My_Random is new Ada.Numerics.Discrete_Random (Int_Slice);

   function Generate_FileName (Length : Positive) return String is 
      G      : My_Random.Generator;  
      I      : Int_Slice;  
      Result : String (1 .. Length);  
   begin
      My_Random.Reset(G);

      for X in 1..Length
            loop
         I := My_Random.Random(G);
         Result(X) := valid_chars(I);
      end loop;
      return Result;
   end Generate_FileName;

begin

   for X in 1..10
   loop
      Put_Line(Generate_Filename(8));
   end loop;

end Random_Test;

---------------

When I put

   subtype Int_Slice is Integer range valid_chars'range;
   package My_Random is new Ada.Numerics.Discrete_Random (Int_Slice);

into the function, nothing changes.

Thanks.